download files from EDS instead of PDS #478
Conversation
|
Builds are failing because the mock-servers used for integration testing don't yet handle the EDS url in the key-value store. Edit: after discussion, it looks like the best thing to do here is just to remove those tests, as they're no longer relevant. |
| def get_download_token( | ||
| self, event_id, device_id, file_path, file_sha256, timestamp | ||
| ): | ||
| def get_download_token(self, downloadRequestUrl): |
There was a problem hiding this comment.
Is this the only customer using this as far as we know? Changing the signature is technically a breaking change - but if its currently broken and/or no ones using it, then its probably okay.
Maybe we could add details about how to adopt the fix in the changelog?
There was a problem hiding this comment.
This method is only used internally and isn't included in the documentation. I suppose it's possible that someone could have been using it directly, but I doubt it.
There was a problem hiding this comment.
Added a note to the changelog.
|
If we're planning to release this right after merging, feel free to do the version bump and the changelog release date in the same PR |
Updates the file download methods to use EDS instead of PDS. Also removes the old fallback to downloading from backup archives, as that is no longer used now that we're on EDS.